Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update terraform required version #336

Merged
merged 2 commits into from
Aug 6, 2021
Merged

update terraform required version #336

merged 2 commits into from
Aug 6, 2021

Conversation

brooke-hamilton
Copy link
Contributor

Description

Changed the required Terraform version number to 1.0.3 in main.tf. (1.0.4 is still built in the dev container.)

Issue reference

The issue this PR will close: #335

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@brooke-hamilton brooke-hamilton enabled auto-merge (squash) August 6, 2021 14:02
glennmusa
glennmusa reviewed Aug 6, 2021
View reviewed changes
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .devcontainer also downloads the specific version of TF

@brooke-hamilton
Copy link
Contributor Author

The .devcontainer also downloads the specific version of TF

I left that on purpose - I think we want our dev container at the current version of TF, but not require it because cloud shell is not at that version yet.

@glennmusa
Copy link
Contributor

glennmusa commented Aug 6, 2021 •
edited
Loading

The .devcontainer also downloads the specific version of TF

I left that on purpose - I think we want our dev container at the current version of TF, but not require it because cloud shell is not at that version yet.

Ah, should we then change the version constraints in main.tf and tier3.tf to reflect >= 1.03 ? As is, running from the .devcontainer will not work, right?

@brooke-hamilton
Copy link
Contributor Author

The .devcontainer also downloads the specific version of TF

I left that on purpose - I think we want our dev container at the current version of TF, but not require it because cloud shell is not at that version yet.

Ah, should we then change the version constraints in main.tf and tier3.tf to reflect >= 1.03 ? As is, running from the .devcontainer will not work, right?

Good call. I tested this change from cloud shell, not from the dev container. I will update to >=.

@brooke-hamilton brooke-hamilton merged commit edfa69f into main Aug 6, 2021
glennmusa
glennmusa approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making sure this works in the cloud shell!

@brooke-hamilton brooke-hamilton deleted the brooke/updatetfversion branch August 6, 2021 17:52
Breanna-Stryker added a commit that referenced this pull request Aug 26, 2021
@Breanna-Stryker @brooke-hamilton
@glennmusa @Chambras @sstjean @shawngib
Update scripted. (#369)
96ef8bf 
* Updated contribution process (#309)

* allow users to bring their own credentials and override MLZ Service Principal creation (#315)

* Update Terraform to version 1.0.3 (#318)

Co-authored-by: Brooke Hamilton <[email protected]>

* updated NOTICE to remove unused licenses (#321)

* Set missing provider on Sentinel LAWS (#326)

* Update Terraform to version 1.0.4 (#334)

* update terraform required version (#336)

* Updating mlz variables file (#338)

* Update azurerm provider to 2.71.0 (#339)

* Updating tier3 variables file (#340)

* Updated issue templates (#349)

- Changed 'Issue' type to 'Backlog Item'
- Consolidated 'Feature request' and 'Enhancement' into 'Enhancement'

* add CODEOWNERS file (#364)

* Updating some modules variables files (#363)

* Add NIST policy assignment off by default (#350)

Co-authored-by: Brooke Hamilton <[email protected]>
Co-authored-by: Glenn Musa <[email protected]>
Co-authored-by: Marcelo Zambrana Villarroel <[email protected]>
Co-authored-by: Steven St Jean <[email protected]>
Co-authored-by: Shawn Gibbs <[email protected]>
Breanna-Stryker added a commit that referenced this pull request Sep 2, 2021
@Breanna-Stryker @Chambras
@brooke-hamilton @shawngib @glennmusa
Merge bicep to working. (#389)
eccc703 
* Update Terraform to version 1.0.4 (#334)

* update terraform required version (#336)

* Updating mlz variables file (#338)

* Update azurerm provider to 2.71.0 (#339)

* Updating tier3 variables file (#340)

* Updated issue templates (#349)

- Changed 'Issue' type to 'Backlog Item'
- Consolidated 'Feature request' and 'Enhancement' into 'Enhancement'

* add CODEOWNERS file (#364)

* Updating some modules variables files (#363)

* Add NIST policy assignment off by default (#350)

* Update Terraform to version 1.0.5 (#372)

* update the diagram (#383)

Co-authored-by: Marcelo Zambrana Villarroel <[email protected]>
Co-authored-by: Brooke Hamilton <[email protected]>
Co-authored-by: Shawn Gibbs <[email protected]>
Co-authored-by: Glenn Musa <[email protected]>
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
@brooke-hamilton
update terraform required version (Azure#336)
1550de2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmusa glennmusa glennmusa approved these changes

@Chambras Chambras Awaiting requested review from Chambras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud shell deployment is broken because of the Terraform version
2 participants
@brooke-hamilton @glennmusa