-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow users to bring their own credentials and override MLZ Service Principal creation #315
Conversation
So far this has been working as expected for me in commercial and gov. I even used a different SP with owner rights which is expected to work, and it did! |
This also worked well for me in commercial, including failure scenarios like the SP not having the contributor role. |
…ssionlz into glennmusa/usersuppliedprincipal
* Updated contribution process (#309) * allow users to bring their own credentials and override MLZ Service Principal creation (#315) * Update Terraform to version 1.0.3 (#318) Co-authored-by: Brooke Hamilton <[email protected]> * updated NOTICE to remove unused licenses (#321) * Set missing provider on Sentinel LAWS (#326) * Update Terraform to version 1.0.4 (#334) * update terraform required version (#336) * Updating mlz variables file (#338) * Update azurerm provider to 2.71.0 (#339) * Updating tier3 variables file (#340) * Updated issue templates (#349) - Changed 'Issue' type to 'Backlog Item' - Consolidated 'Feature request' and 'Enhancement' into 'Enhancement' * add CODEOWNERS file (#364) * Updating some modules variables files (#363) * Add NIST policy assignment off by default (#350) Co-authored-by: Brooke Hamilton <[email protected]> Co-authored-by: Glenn Musa <[email protected]> Co-authored-by: Marcelo Zambrana Villarroel <[email protected]> Co-authored-by: Steven St Jean <[email protected]> Co-authored-by: Shawn Gibbs <[email protected]>
…rincipal creation (Azure#315)
Description
This change proposes adding a
--no-service-principal
flag to deploy.sh in conjunction with two environment variablesARM_CLIENT_ID
andARM_CLIENT_SECRET
to deploy MLZ without creating a brand new Service Principal.This change allows those who do not have
Owner
RBAC permissions but have been given Subscriptions and a Service Principal withContributor
role to those subscriptions to deploy MissionLZ.Two new scripts were introduced with this change:
This script ensures the environment variables
ARM_CLIENT_ID
andARM_CLIENT_SECRET
are set and that the Service Principal exists.This scripts ensures that the user supplied Service Principal has at minimum a
Contributor
RBAC role scoped for each of the subscriptions the user is deploying into and provides the scripts the user would run to remediate the issue.A few good ways to test this:
Deploy with the
--no-service-principal
flag to test the environment variable check:Create yourself a new Service Principal, set the relevant environment variables, and attempt to deploy into multiple subscriptions without assigning the roles:
For more help, check the updated docs.
Issue reference
The issue this PR will close: #176
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck
.vscode/extensions.json
.)