Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create MLZ configuration storage accounts with lowercase names #222

Merged
merged 4 commits into from
May 25, 2021

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented May 25, 2021

Description

  • refactors generate_names.sh to make storage account names with lowercase alphanumeric names
  • attempts to make makes resource-specific names easier to find and modify
  • uses the first octet in a subscription ID to make a randomish_identifier instead of using the full GUID.

Issue reference

The issue this PR will close: #215

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed this with a big upper case deployment name. 👍

@glennmusa glennmusa merged commit f83d387 into main May 25, 2021
@glennmusa glennmusa deleted the glennmusa/storageaccountnames branch May 25, 2021 20:25
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployments fail when environment names containing uppercase characters
2 participants