Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Export/Load #167

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Docker Export/Load #167

merged 4 commits into from
Apr 23, 2021

Conversation

Breanna-Stryker
Copy link
Contributor

@Breanna-Stryker Breanna-Stryker commented Apr 21, 2021

Description

Add export option for docker building
Refactored Docker Build in code order to allow for an exit after a local save
Allow for user to not enter any commands other than docker_strategy=export when exporting
Added sed to dockerfile
Fixed shellcheck recommend on add_auth_scopes.sh

Issue reference

The issue this PR will close: #169

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Breanna-Stryker please create an issue for this PR that has the benefit/result/outcome and the acceptance criteria filled out. This will help understanding of why this PR is being done.

@Breanna-Stryker
Copy link
Contributor Author

@Breanna-Stryker please create an issue for this PR that has the benefit/result/outcome and the acceptance criteria filled out. This will help understanding of why this PR is being done.

Issue #169 Created.

@Breanna-Stryker Breanna-Stryker merged commit 32e9b8b into main Apr 23, 2021
@Breanna-Stryker Breanna-Stryker deleted the dockerbuildexport branch April 23, 2021 03:10
glennmusa pushed a commit that referenced this pull request Apr 23, 2021
* Various fixes and refactor to allow for export and load

* Update documentation.

* Abstract export code to own file, extend to allow file names

* Fix various.

Co-authored-by: Bree Stryker <[email protected]>
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
* Various fixes and refactor to allow for export and load

* Update documentation.

* Abstract export code to own file, extend to allow file names

* Fix various.

Co-authored-by: Bree Stryker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLZ/UI Docker Image Export
3 participants