Resolve transient failure with creating Service Principals in MAG #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmusa
suggested changes
Apr 1, 2021
glennmusa
suggested changes
Apr 6, 2021
| @@ -27,6 +27,19 @@ This process will build the user interface container image on your workstation u | |||
| Log in using the Azure CLI | |||
|
|
|||
| ```BASH | |||
There was a problem hiding this comment.
I think these changes are unrelated to the PR
There was a problem hiding this comment.
I was just trying to cleanup the documentation some as I run across things that need to be fixed or modified for clarity. Should I not do that here in this PR?
glennmusa
reviewed
Apr 6, 2021
glennmusa
approved these changes
Apr 6, 2021
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
…ure#122) * - Added code to account for SP transient error * - Added max wait for SP and messages * - Added wait login for SP objecut ID as well * - Fixed sample path in Azure Installation steps * - Removed trailing " setup_ezdeploy.sh cmd line example * - Modified loop logic * - Modified script example for clarity * - Updated loop logic for Service Principal creation * - Moved loop logic to function * - Added missing $ for variable usage Co-authored-by: Brooke Hamilton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added code to provide wait after creating Service Principal. In MAG, querying for the AppId and ObjectId directly after executing the SP create fails a high percentage of the time with the error saying it could not find the requested Service Principal
Issue reference
The issue this PR will close: #106
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)