Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore *.tfvars.json files #105

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Ignore *.tfvars.json files #105

merged 3 commits into from
Mar 25, 2021

Conversation

sstjean
Copy link
Contributor

@sstjean sstjean commented Mar 24, 2021

Description

Updated the .gitignore to ignore all .tfvars.json files so that we can work with multiple sets of configs locally without those files polluting the repo.

Issue reference

Closes #104

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@brooke-hamilton
Copy link
Contributor

@Breanna-Stryker, does the UI depend on the *.tfvars.json files being in the repo? In other words, will the UI create these if they do not exist?

@sstjean
Copy link
Contributor Author

sstjean commented Mar 24, 2021

@Breanna-Stryker pinged me offline with the following: "Since I am out and about I will reply directly. It does require the orig.tfvars.json to be present."

I've updated the file to allow tracking of *.orig.tfvars.json files.

@sstjean sstjean enabled auto-merge (squash) March 25, 2021 19:14
@sstjean sstjean closed this Mar 25, 2021
auto-merge was automatically disabled March 25, 2021 19:14

Pull request was closed

@sstjean sstjean enabled auto-merge (squash) March 25, 2021 20:07
@sstjean sstjean merged commit e84d990 into main Mar 25, 2021
@sstjean sstjean deleted the sstjean-gitignore branch March 25, 2021 20:09
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
* Ignore *.tfvars.json files

* Updated to leave *.orig.tfvars.json files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .gitignore to filter out .tfvars.jason files
2 participants