Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_ezdeploy.sh attempts to set the role assignment on same sub multiple times #120

Closed
Phydeauxman opened this issue Mar 26, 2021 · 2 comments · Fixed by #143
Closed
Assignees

Comments

@Phydeauxman
Copy link
Contributor

Description
When running the setup_ezdeploy.sh script it attempts to assign the contributor role to the Service Principal it creates on the subscription for each tier even if the same sub is used for all tiers.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Run setup_ezdeploy.sh using a single subscription for each tier

Expected behavior
setup_ezdeploy.sh should determine how many unique subs were entered and only attempt to assign the role once for each unique sub

Actual behavior
Attempts to assign role to each sub

@brooke-hamilton
Copy link
Contributor

@Phydeauxman what is the impact of setting the same role multiple times on a single sub?

For a fix, how about using the AZ CLI to check the role assignments to see if the contributor role is already assigned, and skip the assignment if it's already there?

@Phydeauxman
Copy link
Contributor Author

@brooke-hamilton no harm in attempting to set it more than once but we had already cleaned this up in the manual execution scripting. Going to add the code we created for that to the setup_ezdeploy.sh script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants