Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spark.hadoop.fs.azure properties needed for NativeAzureFileSy… #43

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

andrijaperovic
Copy link
Contributor

…stem to work correctly in spark context
Please see:
#41

@andrijaperovic
Copy link
Contributor Author

Can you please take a look @jainr @snowmanmsft
++ @rramani

@jainr
Copy link
Member

jainr commented Jan 28, 2022

Thanks for the contribution, can you also add an else block which tells user that they need to set those params if not found?

@andrijaperovic
Copy link
Contributor Author

Thanks for the contribution, can you also add an else block which tells user that they need to set those params if not found?

@jainr i believe these are already standard feast Azure environment variables. They are referenced in the historical features python notebook.

@jainr
Copy link
Member

jainr commented Jan 28, 2022

Looks good, approving it.

@jainr jainr merged commit 013010d into Azure:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants