Issue with StarterKit Files

[martyh888]

Issues with StarterKit files where name of definition has spaces

policyDefinitions/Defender/azure-defender-enroll.json

This following throws the error due to spaces and not using "-" instead

New-AzPolicyDefinition: /home/vsts/work/1/s/Scripts/Deploy/Deploy-PolicyPlan.ps1:208
Line |
 208 |              $null = New-AzPolicyDefinition @policyDefinition
     |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | MismatchedPolicyDefinitionName : The policy definition name
     | 'EnableAzureDefenderforResourceType' in the request body does not match
     | the policy definition name 'Enable Azure Defender for Resource Type' in
     | the request uri. CorrelationId: f6e0eade-9bfd-4df6-9863-514d6a534d12

Need to fix this

"name": "Enable Azure Defender for Resource Type",

And also fix file Definitions/policySetDefinitions/defender-dine-enable-for-subscription-initiative.jsonc to be the same as what the name is changed to above

[techlake]

This is caused by a bug in Az PowerShell Module 9.2.x. It is fixed in 9.3.0. I will add a big warning to the README.md file tomorrow.
Please update the version on your runner.

[martyh888]

Will this also fix this issue

[martyh888]

Thanks all good working now with this change in pipeline

Replaced this line in all occurrences in pipeline

azurePowerShellVersion: LatestVersion

with this

preferredAzurePowerShellVersion: "9.3.0"

[techlake]

Great. I'll put that in the README file. Your fix above is a partial fix. The bug in 9.2.x removes all spaces in any of the values. It breaks display names, descriptions, even parameter values in assignments. See Azure/azure-powershell#20407.

[techlake]

Microsoft hosted agents have been upgraded as of today 1/23/2023. The solution is working again correctly.

[techlake]

Actually, some are updated, some are still on 9.2.0. Try again tomorrow when all images should be rolled over.