Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release for draft info and other fixes #161

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

davidgamero
Copy link
Collaborator

Description

Added

  • The new draft info command from draft info command proposal #157 prints supported language and field information in json format.
  • An integration test was added for the installation shell script to better ensure that the script works as expected.

Fixed

  • File path output for root locations had a bug with string-formatted paths. The path.Join method has been substituted to fix this.

Changed

  • Remaining uses of the viper library have been migrated to gopkg.in/yaml.v3 for consistency.
  • Unused files in the web package have been removed.
  • Minor reorganization across the config and addons packages to reduce the number of exported functions and types.

Type of change

Release

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@davidgamero davidgamero marked this pull request as ready for review November 16, 2022 16:31
qpetraroia
qpetraroia previously approved these changes Nov 16, 2022
Tatsinnit
Tatsinnit previously approved these changes Nov 16, 2022
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 🎊 Thanks for adding me to this review, I have added something which we can remove, please feel free to take a look and decide. Thanks.

CHANGELOG.md Outdated Show resolved Hide resolved
@davidgamero davidgamero dismissed stale reviews from Tatsinnit and qpetraroia via 7c6ccc4 November 16, 2022 22:58
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉❤️☕️

@davidgamero davidgamero merged commit 7a5311e into Azure:main Nov 17, 2022
@davidgamero davidgamero deleted the info-release branch April 18, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants