Always convert the sort key to an integer when sorting node names #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditigaur4
reviewed
Nov 1, 2024
| @@ -174,7 +174,7 @@ def _node_index_as_sort_key(nodename: str) -> Union[str, int]: | |||
| try: | |||
| return int(nodename.split("-")[-1]) | |||
| except Exception: | |||
| return nodename | |||
| return int.from_bytes(nodename.encode(), byteorder="little") | |||
|
|
|||
|
|
|||
| def _node_index_and_pg_as_sort_key(nodename: str) -> Union[str, int]: | |||
There was a problem hiding this comment.
Does the same change need to be applied in line 189 as well?
|
I need to approve this for now to get the pre-release out but i think this PR might be incomplete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes str vs int comparison bug by always converting the key to an integer. In this case, simply convert the string as bytes into an integer.