Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requests from setup.py/dev-requirements #268

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

ryanhamel
Copy link
Collaborator

No description provided.

@ryanhamel ryanhamel requested a review from bwatrous July 9, 2024 19:54
Copy link
Contributor

@bwatrous bwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one... Should we keep the explicit dependency and just bump the version?
Seems like this project directly depends on requests:

slurm/src/slurmcc/init.py:import requests
slurm/src/slurmcc/init.py: [RuntimeError, ValueError, requests.exceptions.ConnectionError]

@ryanhamel
Copy link
Collaborator Author

That use if requests is only for live testing with a chaos mode which would have scalelib installed. I now handle missing requests library if that module is imported without requests.

@ryanhamel ryanhamel merged commit 2b27086 into master Jul 15, 2024
3 checks passed
@ryanhamel ryanhamel deleted the ryhamel/update-depends branch July 15, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants