Fix manual suspend and avoid KeepAlive=true resume/resume_fail loop via new azslurm return_to_idle command #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 8, 2024
aditigaur4
reviewed
May 17, 2024
added 3 commits
July 15, 2024 16:41
… CycleCloud Set KeepAlive=true nodes to down so that they can be ignored by slurm Undo internal DNS records of suspended nodes, and set the state back to future for non-autoscale clusters Fixes: #238
ryanhamel
force-pushed
the
ryhamel/fix-manual-suspend
branch
from
f4f1425
to
85ea951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with manually suspending nodes that do not use nodename==hostname.
Also fixes KeepAlive issues where the nodes would resume/resume_failed in a loop forever.
Adds azslurm return_to_idle command to help with this, rather than the pure shell implementation.