Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows runner for Azure keyvault #101

Open
Kebechet opened this issue Mar 2, 2023 · 6 comments
Open

Windows runner for Azure keyvault #101

Kebechet opened this issue Mar 2, 2023 · 6 comments
Assignees
Labels
idle Inactive for 14 days need-to-triage Requires investigation stale 90 days old

Comments

@Kebechet
Copy link

Kebechet commented Mar 2, 2023

Azure cli should be the replacement for: https://github.com/Azure/get-keyvault-secrets
for retrieving secrets from Azure key vault. But the old get-keyvault-secrets worked also on windows runner but Azure cli does not because of the check:

https://github.com/Azure/cli/blob/master/src/main.ts#L19

if (process.env.RUNNER_OS != 'Linux') {
    core.setFailed('Please use Linux based OS as a runner.');
    return;
}

get-keyvault-secrets is going to be deprecated, so how to make Azure/cli work for windows runners ?

@Kebechet Kebechet added the need-to-triage Requires investigation label Mar 2, 2023
@Kebechet Kebechet changed the title Windows runner Windows runner for Azure keyvault Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This issue is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale 90 days old label Mar 9, 2023
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Mar 16, 2023
@MoChilia MoChilia added feature-request and removed stale 90 days old idle Inactive for 14 days need-to-triage Requires investigation labels Apr 19, 2023
@MoChilia MoChilia assigned MoChilia and unassigned bishal-pdMSFT and t-dedah Apr 19, 2023
@github-actions
Copy link

This issue is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale 90 days old label Apr 26, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label May 3, 2023
@MoChilia MoChilia added need-to-triage Requires investigation and removed feature-request labels May 6, 2023
@MacKey-255
Copy link

Any news?

@MoChilia
Copy link
Member

Hi @MacKey-255, Azure/cli is designed to use docker in the action for running Azure CLI scripts. The docker image built by azure-cli provides a standalone Linux container. But Linux containers cannot run directly on Windows. Implementing support for Windows runners would require significant effort and need collaboration with azure-cli. Thanks for your patience and hope for your understanding in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days need-to-triage Requires investigation stale 90 days old
Projects
None yet
Development

No branches or pull requests

5 participants