Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Incorrect private endpoint deployment for app service slots #3826

Open
1 task done
rabiexxx opened this issue Nov 21, 2024 · 5 comments
Open
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@rabiexxx
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/web/site

(Optional) Module Version

No response

Description

When declaring deployment slots with private endpoint using the app service module, the private endpoints are created. However, private endpoint that should be attached to the deployment slot are created but attached to the main ( production slot ) of the app service.


module appService 'br/public:avm/res/web/site:0.11.1' = {
  name: '${uniqueString(deployment().name)}-app-service'
  params: {
    name: '${name}-${dtap}-${commonparams.namerefs.appService}'
    kind: kind
    location: commonparams.location
    serverFarmResourceId: appServicePlanId
    publicNetworkAccess: publicNetworkAccess
    privateEndpoints: empty(PrivateEndpointSubnetId)
      ? []
      : [
          {
            subnetResourceId: PrivateEndpointSubnetId
            service: 'sites'
          }
        ]
    virtualNetworkSubnetId: virtualNetworkSubnetId
    managedIdentities: {
      systemAssigned: systemManagedIdentity
      userAssignedResourceIds: empty(userAssignedManagedIdentityResourceId)
        ? []
        : [userAssignedManagedIdentityResourceId]
    }

    // Non-required parameters
    appInsightResourceId: appInsightResourceId
    appSettingsKeyValuePairs: appSettings
    siteConfig: union(baseSiteConfig, siteConfig)
    slots: [
      for slot in slots: {
        name: '${slot}'
        publicNetworkAccess: publicNetworkAccess
        siteConfig: union(baseSiteConfig, siteConfig)

>         privateEndpoints: empty(slotPrivateEndpointSubnetId)
>           ? []
>           : [
>               {
>                 name: 'pe-${name}-${slot}'
>                 subnetResourceId: slotPrivateEndpointSubnetId
>                 service: 'sites'
>               }
>             ]

        diagnosticSettings: [
          {
            name: '${name}-${slot}-diagnostics'
            workspaceResourceId: logWorkspaceResourceId
          }
        ]
      }
    ]
    vnetImagePullEnabled: vnetImagePullEnabled
    diagnosticSettings: [
      {
        name: '${name}-${dtap}-diagnosticSettings'
        workspaceResourceId: logWorkspaceResourceId
        logCategoriesAndGroups: [
          {
            categoryGroup: 'allLogs'
            enabled: true
          }
        ]
        metricCategories: [
          {
            category: 'AllMetrics'
          }
        ]
      }
    ]
    tags: commonparams.tags
  }
}

(Optional) Correlation Id

No response

@rabiexxx rabiexxx added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 21, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Nov 21, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Nov 21, 2024
Copy link

@rabiexxx, thanks for submitting this issue for the avm/res/web/site module!

Important

A member of the @Azure/avm-res-web-site-module-owners-bicep or @Azure/avm-res-web-site-module-contributors-bicep team will review it soon!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Nov 27, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Status: Needs: Triage
Development

No branches or pull requests

2 participants