Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TOKEN_FILE_PATH env variable to be more relevant #56

Closed
1 of 2 tasks
aramase opened this issue Jun 4, 2021 · 2 comments · Fixed by #158
Closed
1 of 2 tasks

Update TOKEN_FILE_PATH env variable to be more relevant #56

aramase opened this issue Jun 4, 2021 · 2 comments · Fixed by #158
Assignees
@aramase
Labels
enhancement New feature or request webhook
Milestone
v0.4.0

Comments

@aramase
Copy link
Member

aramase commented Jun 4, 2021 •
edited by chewong
Loading

TOKEN_FILE_PATH is too generic. We should switch to using an env var name that's more relevant for consumption with the SDK.
@aramase aramase added the enhancement New feature or request label Jun 4, 2021
@aramase aramase added this to the v0.2.0 milestone Jun 4, 2021
@aramase aramase modified the milestones: v0.2.0, v0.3.0 Jun 25, 2021
@aramase
Copy link
Member Author

aramase commented Jul 21, 2021

The current plan is to continue using TOKEN_FILE_PATH as it's generic. We can plan on changing this in a later iteration.

@aramase aramase removed this from the v0.3.0 milestone Jul 21, 2021
@aramase aramase self-assigned this Aug 4, 2021
@aramase aramase mentioned this issue Aug 4, 2021
Merged
5 tasks
@aramase aramase added this to the v0.4.0 milestone Aug 4, 2021
@aramase
Copy link
Member Author

aramase commented Aug 24, 2021

The PR to update has been merged.

Pending: Documentation update.

@aramase aramase mentioned this issue Aug 26, 2021
Merged
5 tasks
@aramase aramase moved this to Done in Roadmap Oct 28, 2022
@aramase aramase added this to Roadmap Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aramase aramase

Labels
enhancement New feature or request webhook
Projects
Roadmap
Status: Done
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

test: reenable upgrade tests and update validate mutated pod check
1 participant
@aramase