Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make proxy port configurable in init-iptables.sh #178

Merged
merged 1 commit into from
Sep 13, 2021
Merged

fix: make proxy port configurable in init-iptables.sh #178

merged 1 commit into from
Sep 13, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 13, 2021

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

Makes the proxy port, metadata IP and metadata port configurable in the proxy-init script using PROXY_PORT, METADATA_IP, METADATA_PORT.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #177

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase marked this pull request as ready for review September 13, 2021 18:47
@aramase aramase requested a review from chewong as a code owner September 13, 2021 18:47
Copy link
Contributor

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove EXPOSE 8000 in proxy.Dockerfile.

@aramase aramase enabled auto-merge (squash) September 13, 2021 19:00
@aramase aramase merged commit aeebf23 into Azure:main Sep 13, 2021
@aramase aramase deleted the init-iptables-port branch September 13, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init-iptables.sh is hardcoded to port 8000
2 participants