Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: poll for service account creation and webhook readiness #125

Merged
merged 1 commit into from
Aug 5, 2021
Merged

test: poll for service account creation and webhook readiness #125

merged 1 commit into from
Aug 5, 2021

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Jul 30, 2021

Signed-off-by: Ernest Wong [email protected]

Reason for Change:

Fixes #114
Fixes #122

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

scripts/ci-e2e.sh Outdated Show resolved Hide resolved
@chewong chewong changed the title test: poll for SA creation and add --overwrite-existing when getting KUBECONFIG test: poll for service account creation Aug 4, 2021
@chewong chewong changed the title test: poll for service account creation test: poll for service account creation and webhook readiness Aug 4, 2021
@chewong chewong marked this pull request as ready for review August 5, 2021 02:18
@chewong chewong requested a review from aramase August 5, 2021 02:18
@chewong chewong enabled auto-merge (squash) August 5, 2021 16:26
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
test/e2e/helpers.go Outdated Show resolved Hide resolved
@chewong chewong requested a review from aramase August 5, 2021 16:38
@chewong
Copy link
Contributor Author

chewong commented Aug 5, 2021

VM should have Go properly installed so I am removing templates/setup-go.yaml in this PR.

@chewong chewong merged commit 3e7f609 into Azure:main Aug 5, 2021
@aramase aramase deleted the fix-114-122 branch August 5, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants