feat: Add new authentication type UserAssignedIdentityCredential #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryan-cox
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
bryan-cox
changed the title
|
@microsoft-github-policy-service agree [company="{Red Hat}"] |
|
@microsoft-github-policy-service agree company="Red Hat" |
bryan-cox
force-pushed
the
userassignedcreds
branch
from
0fc02aa to
d91ef61
Compare
|
/retest |
That's not a command we've installed in this repo. ;-) I've triggered CI to run again for you. |
bryan-cox
force-pushed
the
userassignedcreds
branch
2 times, most recently
from
d8b66ae to
6333c93
Compare
bryan-cox
force-pushed
the
userassignedcreds
branch
from
6333c93 to
f9a8795
Compare
This commit adds a new authentication type, UserAssignedIdentityCredentials. This allows a 1st party Microsoft application to authenticate using a managed identity's certificate, which is accessed through the MSI data plane. More information on this authentication type can be found here - https://github.com/Azure/msi-dataplane/blob/63fb37d3a1aaac130120624674df795d2e088083/pkg/dataplane/reloadCredentials.go#L60. Signed-off-by: Bryan Cox <[email protected]>
Signed-off-by: Bryan Cox <[email protected]>
bryan-cox
force-pushed
the
userassignedcreds
branch
from
f9a8795 to
79829d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pull request adds the capability to authenticate with Azure using a new authentication type available only to 1st party Microsoft applications, UserAssignedIdentityCredential. More information on this new authentication type can be found here - https://github.com/Azure/msi-dataplane/blob/main/pkg/dataplane/reloadCredentials.go#L60.
Checklist