Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support resources needed by CAPZ #2237

Closed
5 of 9 tasks
matthchr opened this issue Apr 13, 2022 · 12 comments
Closed
5 of 9 tasks

Feature: Support resources needed by CAPZ #2237

matthchr opened this issue Apr 13, 2022 · 12 comments
Labels
new-feature new-resource Requests for new supported resources
Milestone

Comments

@matthchr
Copy link
Member

matthchr commented Apr 13, 2022

The list of resources we are currently lacking for CAPZ is:

The full list of in-use services can be found here: https://github.com/kubernetes-sigs/cluster-api-provider-azure/tree/master/azure/services

@matthchr
Copy link
Member Author

I just realized that we already support Peerings. Updated the list to reflect that

@nojnhuh
Copy link
Member

nojnhuh commented Apr 6, 2023

Resource health also falls into this category: #2762

CAPZ also uses privatdns.VirtualNetworkLinks and privatedns.RecordSets and I can't quite tell if those are supported in ASO? I see PrivateDnsZonesVirtualNetworkLink and the record types listed here: https://azure.github.io/azure-service-operator/reference/. But there's no sample YAML and I don't see them listed anywhere on this page: https://azure.github.io/azure-service-operator/reference/network/v1beta20180901/.

Otherwise I took another look through the list and everything looks up to date 👍

@matthchr
Copy link
Member Author

matthchr commented Apr 6, 2023

Yes we support RecordSets and VirtualNetworkLinks. IIRC both of these were added for the upcoming v2.0.0 release and they aren't on the full website yet because that release hasn't gone out yet, but they will be there shortly.

@dtzar
Copy link

dtzar commented Apr 6, 2023

@matthchr - can you please reflect the latest status with the checklist of items at the top of this description? I can see it hasn't been updated since April 2022.

@mboersma
Copy link
Member

mboersma commented Apr 14, 2023

Assuming this list represents ASO services currently implemented, I don't see any delta with CAPZ services: https://github.com/kubernetes-sigs/cluster-api-provider-azure/tree/main/azure/services.

@mattchr are there still gaps here?

@matthchr
Copy link
Member Author

matthchr commented Apr 15, 2023

Yes there are definitely some gaps here.

ASO has a list of supported resources here: https://azure.github.io/azure-service-operator/reference/

I believe the checklist above is correct. We do not currently have support for:

The rest of the resources CAPZ uses I believe we have support for already.

@mboersma
Copy link
Member

I believe the checklist above is correct.

Excellent, thank you for the confirmation @matthchr! I'll use this list to try to fill in the gaps for CAPZ with SDK v2 until these resources are implemented in ASO.

@matthchr
Copy link
Member Author

Rather than tracking this as a block, I've broken out individual items for the above. I edited them in to my post above and the original issue.

I'll close this in favor of those once we get clarity on what these two things actually are:

  • VirutalMachineImages (not 100% sure what this is actually?)
  • ScaleSetVMs (I think from looking at CAPZ code this is related to VMSS Flex, since with uniform you dont provision VMs you just edit the parent VMSS?)

Which ARM resources do these refer to?

@matthchr
Copy link
Member Author

I've added a CAPZ label for now to track this work too: capz Required for CAPZ ASO adoption

@matthchr
Copy link
Member Author

@matthchr
Copy link
Member Author

and here's ScaleSet VMs issue: #2895

It's also not a real resource but it seems a reasonable ask for there to be a way to manage individual VMs through the ASO API.

@matthchr
Copy link
Member Author

I'm closing this in favor of all of the linked issues above that can track things at a more granular level. Use the capz Required for CAPZ ASO adoption label for an aggregate view of what more needs to be done.

@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Apr 18, 2023
@matthchr matthchr moved this from Recently Completed to Ready for Release in Azure Service Operator Roadmap Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature new-resource Requests for new supported resources
Projects
Development

No branches or pull requests

4 participants