Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI does not warn that a merge containing a new folder will break the build #498

Closed
danieljurek opened this issue Jul 15, 2019 · 3 comments
Closed
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Comments

@danieljurek
Copy link
Member

A change that introduced a new folder in the .NET Repo (Azure/azure-sdk-for-net#6652) has resulted in build breaks during the "Verify Readmes" step in the Scheduled Build Analyze step.

While the issue was quickly mitigated by adding an exclusion to the readme verifier we should consider a broader fix or a way to find out that we'll have this problem in CI.

@danieljurek
Copy link
Member Author

@danieljurek danieljurek added the EngSys This issue is impacting the engineering system. label Jul 15, 2019
@danieljurek
Copy link
Member Author

danieljurek commented Jul 15, 2019

Spoke w/ @scbedd about this. We have a plan for fixing this:

The readme verifier was designed to find errors and should be extended to work with additional scenarios.

In the short term, to get these tests running for PRs /azp run command to kick off the appropriate language client build (e.g. /azp run net - client

Copy link

Hi @danieljurek, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-project-automation github-project-automation bot moved this from 🤔 Triage to 🎊 Closed in Azure SDK EngSys 🚢🎉 Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
Archived in project
Development

No branches or pull requests

2 participants