Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board Review: BearerTokenChallengePolicy in Core [Python] #4302

Closed
annatisch opened this issue May 11, 2022 · 2 comments
Closed

Board Review: BearerTokenChallengePolicy in Core [Python] #4302

annatisch opened this issue May 11, 2022 · 2 comments
Assignees
Labels
architecture board-review Request for an Architectural Board Review

Comments

@annatisch
Copy link
Member

annatisch commented May 11, 2022

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.

The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.

Please reference our review process guidelines to understand what is being asked for in the issue template.

To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together. In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.

For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.

Before submitting, ensure you adjust the title of the issue appropriately.

Note that the required material must be included before a meeting can be scheduled.

This review is to discuss the addition of a new auth policy for multi-tenant authentication to azure core for Python (other languages may follow). This policy will be consumed by both Keyvault and Tables with potentially more services in future.

A 1-hour slot should be sufficient.

Contacts and Timeline

  • Responsible service team: Python Core team
  • Main contacts: McCoy Patiño, Anna Tisch, Laurent Mazuel
  • Expected code complete date: 1st June
  • Expected release date: 6th June

About the Service

  • Link to documentation introducing/describing the service:
  • Link to the service REST APIs:
  • Link to GitHub issue for previous review sessions, if applicable:

About the client library

  • Name of the client library: azure-core
  • Languages for this review: Python

Artifacts required (per language)

Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.

Python

  • APIView Link: link
  • Link to Champion Scenarios/Quickstart samples:
    • PR to introduce policy to Azure Core: link
    • PR of Key Vault adoption prototype: link
    • PR that incorporated Tables-internal implementation of proposed policy: link
    • azure-storage-blob's current internal challenge auth policy: link

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.

Thank you!

@annatisch annatisch added architecture board-review Request for an Architectural Board Review labels May 11, 2022
@kyle-patterson
Copy link
Member

Scheduled for 6/1

@tg-msft
Copy link
Member

tg-msft commented Jun 1, 2022

Recording (MS INTERNAL ONLY)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture board-review Request for an Architectural Board Review
Projects
None yet
Development

No branches or pull requests

5 participants