From f2186f30c51b8727bddd3530dfd19ef949d46bbe Mon Sep 17 00:00:00 2001 From: scbedd <45376673+scbedd@users.noreply.github.com> Date: Tue, 27 Jun 2023 15:55:17 -0700 Subject: [PATCH 1/2] disable gpg sign and eliminate edgecase of having GPG signing enabled while pushing a lightweight tag --- tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs index 030572103d1..f5648bfeece 100644 --- a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs +++ b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs @@ -138,7 +138,7 @@ public async Task Push(string pathToAssetsJson) { throw GenerateInvokeException(SHAResult); } - GitHandler.Run($"tag {generatedTagName}", config); + GitHandler.Run($"tag -c tag.gpgsign=false {generatedTagName}", config); var remoteResult = GitHandler.Run($"ls-remote origin --tags {generatedTagName}", config); From 01650664553360043cf655ade0803d35d61e5155 Mon Sep 17 00:00:00 2001 From: scbedd <45376673+scbedd@users.noreply.github.com> Date: Tue, 27 Jun 2023 16:41:13 -0700 Subject: [PATCH 2/2] disallow signing via supported parameter --- tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs index f5648bfeece..06b50a27858 100644 --- a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs +++ b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs @@ -138,7 +138,7 @@ public async Task Push(string pathToAssetsJson) { throw GenerateInvokeException(SHAResult); } - GitHandler.Run($"tag -c tag.gpgsign=false {generatedTagName}", config); + GitHandler.Run($"tag --no-sign {generatedTagName}", config); var remoteResult = GitHandler.Run($"ls-remote origin --tags {generatedTagName}", config);