From bfe75a9325489cfb817e97cabfb3b97d7b2c2ab3 Mon Sep 17 00:00:00 2001 From: Harsha Nalluru Date: Thu, 11 May 2023 14:31:12 -0700 Subject: [PATCH] Update RecordMatcher.cs Ignoring the "Accept-Language" header @timovv shared the discomfort about the number of times he had to re-record because his locale is en-CA instead of en-US. And @jeremymeng 's puppeteer upgrade may unveil a pain later on, example below ``` RecorderError: Unable to find a record for the request POST https://keyvault_name.vault.azure.net/keys/listKeyName-cangettheversionsofakeypaged-/create?api-version=7.4 Header differences: values differ, request <"HeadlessChrome";v="113", "Chromium";v="113", "Not-A.Brand";v="24">, record <> is absent in request, value Body differences: ``` `sec-ch-ua` is just fixed in #6151 --- .../Azure.Sdk.Tools.TestProxy/Common/RecordMatcher.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/RecordMatcher.cs b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/RecordMatcher.cs index b320e79bf73..9766e816943 100644 --- a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/RecordMatcher.cs +++ b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/RecordMatcher.cs @@ -63,7 +63,8 @@ public RecordMatcher(bool compareBodies = true, bool ignoreQueryOrdering = false "Referrer", "Referer", "Origin", - "Content-Length" + "Content-Length", + "Accept-Language" }; ///