From 03a3d7d173ac3684fb8204cf8b372b059218badb Mon Sep 17 00:00:00 2001 From: Scott Beddall Date: Thu, 2 Jun 2022 16:07:35 -0700 Subject: [PATCH 1/2] ensure conditions all work properly in the case of a previous error --- eng/common/pipelines/templates/steps/credscan.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/eng/common/pipelines/templates/steps/credscan.yml b/eng/common/pipelines/templates/steps/credscan.yml index 0171c79d0d2..8a2e53748ab 100644 --- a/eng/common/pipelines/templates/steps/credscan.yml +++ b/eng/common/pipelines/templates/steps/credscan.yml @@ -28,6 +28,8 @@ steps: Write-Host "##vso[task.setvariable variable=SKIP_CREDSCAN]true" } displayName: CredScan setup + condition: succeededOrFailed() + - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@3 displayName: CredScan running condition: and(succeededOrFailed(), ne(variables['SKIP_CREDSCAN'], true)) From 37206e9e650a4a0c8092b31ed95c6479e28c84ed Mon Sep 17 00:00:00 2001 From: Scott Beddall Date: Wed, 26 Apr 2023 14:28:21 -0700 Subject: [PATCH 2/2] update readme to match reality, a follow-up issue is necessary to address rolling out the fixed behavior --- tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md index 2e3067b10e1..9abf4d1d41d 100644 --- a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md +++ b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md @@ -581,11 +581,9 @@ The test-proxy offers further customization beyond that offered by sanitizers, m ### Redirection Settings -The test-proxy does NOT transparent follow redirects by default. That means that if the initial request sent by the test-proxy results in some `3XX` redirect status, it **will not** follow. It will return that redirect response to the client to allow THEM to handle the redirect. +The test-proxy follows redirects by default. That means that if the initial request sent by the test-proxy results in some `3XX` redirect status, it **will follow the redirect**. -In certain cases, this is not a possibility for the client. Javascript Browser tests are a great example of this. Since both "modes" are supported, the test-proxy exposes this as a setting `HandleRedirects`. - -To set this setting, POST to the `/Admin/SetRecordingOptions` route. +In certain cases, a user will want to utilize both behaviors in their tests. For instance, the javascript `browser` tests run with redirect enabled, however for their `node` versions, the redirect functionality is explicitly disabled. The test-proxy exposes this as a setting `HandleRedirects` within the settings object POST-ed to `/Admin/SetRecordingOptions`. Example: