From a6b2415049f8ac12395f4fb8e9b49885f788bbaf Mon Sep 17 00:00:00 2001 From: Konrad Jamrozik Date: Mon, 13 Feb 2023 13:29:21 -0800 Subject: [PATCH 1/3] clarify why we need 'sdk' in UseDotNet@2 --- eng/pipelines/templates/steps/install-dotnet.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/eng/pipelines/templates/steps/install-dotnet.yml b/eng/pipelines/templates/steps/install-dotnet.yml index 06a8d129b72..e839acb6e5b 100644 --- a/eng/pipelines/templates/steps/install-dotnet.yml +++ b/eng/pipelines/templates/steps/install-dotnet.yml @@ -16,7 +16,15 @@ steps: retryCountOnTaskFailure: 3 inputs: # We must install sdk, not just runtime, as it is required by some of our tools, like test-proxy. - # For additional context, see PR: https://github.com/Azure/azure-sdk-tools/pull/5405 + # Specifically, test-proxy requires asp.net core runtime, which is installed only when sdk option + # is selected, per: https://github.com/microsoft/azure-pipelines-tasks/issues/14405 + # + # Build showing the lack of runtime when 'runtime' is used instead of 'sdk': + # https://dev.azure.com/azure-sdk/public/_build/results?buildId=2177474&view=logs&j=f285c022-fd09-5cd2-85b4-c0252bc68dbc&t=1e6dcdea-6b31-5539-122f-c6b9e4b7da81 + # + # For additional context, see: + # https://github.com/Azure/azure-sdk-tools/pull/5405#discussion_r1105006774 + # https://github.com/Azure/azure-sdk-tools/pull/5405 packageType: sdk version: 6.0.x # performMultiLevelLookup comes into play when given .NET executable target runtime is different From 45c904e9d132d7fcf7563970a68acee630929087 Mon Sep 17 00:00:00 2001 From: Konrad Jamrozik Date: Mon, 13 Feb 2023 13:32:52 -0800 Subject: [PATCH 2/3] Update eng/pipelines/templates/steps/install-dotnet.yml --- eng/pipelines/templates/steps/install-dotnet.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/pipelines/templates/steps/install-dotnet.yml b/eng/pipelines/templates/steps/install-dotnet.yml index e839acb6e5b..2ac2e9f8e43 100644 --- a/eng/pipelines/templates/steps/install-dotnet.yml +++ b/eng/pipelines/templates/steps/install-dotnet.yml @@ -19,7 +19,7 @@ steps: # Specifically, test-proxy requires asp.net core runtime, which is installed only when sdk option # is selected, per: https://github.com/microsoft/azure-pipelines-tasks/issues/14405 # - # Build showing the lack of runtime when 'runtime' is used instead of 'sdk': + # Build showing the lack of asp.net core runtime when 'runtime' is used instead of 'sdk': # https://dev.azure.com/azure-sdk/public/_build/results?buildId=2177474&view=logs&j=f285c022-fd09-5cd2-85b4-c0252bc68dbc&t=1e6dcdea-6b31-5539-122f-c6b9e4b7da81 # # For additional context, see: From 5e5aaf0f5dfc43b5ca8f3596c4c19a579e4ae971 Mon Sep 17 00:00:00 2001 From: Konrad Jamrozik Date: Mon, 13 Feb 2023 15:56:20 -0800 Subject: [PATCH 3/3] Remove link to build --- eng/pipelines/templates/steps/install-dotnet.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/eng/pipelines/templates/steps/install-dotnet.yml b/eng/pipelines/templates/steps/install-dotnet.yml index 2ac2e9f8e43..9e2c9d2769e 100644 --- a/eng/pipelines/templates/steps/install-dotnet.yml +++ b/eng/pipelines/templates/steps/install-dotnet.yml @@ -19,9 +19,6 @@ steps: # Specifically, test-proxy requires asp.net core runtime, which is installed only when sdk option # is selected, per: https://github.com/microsoft/azure-pipelines-tasks/issues/14405 # - # Build showing the lack of asp.net core runtime when 'runtime' is used instead of 'sdk': - # https://dev.azure.com/azure-sdk/public/_build/results?buildId=2177474&view=logs&j=f285c022-fd09-5cd2-85b4-c0252bc68dbc&t=1e6dcdea-6b31-5539-122f-c6b9e4b7da81 - # # For additional context, see: # https://github.com/Azure/azure-sdk-tools/pull/5405#discussion_r1105006774 # https://github.com/Azure/azure-sdk-tools/pull/5405 @@ -32,4 +29,4 @@ steps: performMultiLevelLookup: true # Future work: add NuGet packages caching. See: -# https://github.com/Azure/azure-sdk-tools/issues/5086 \ No newline at end of file +# https://github.com/Azure/azure-sdk-tools/issues/5086