Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same-version API check (Swagger BreakingChange) should add VersioningReviewRequired instead of BreakingChangeReviewRequired when detecting issues on preview versions (as opposed to GA) (breaking changes confusion matrix) #7724

Closed
konrad-jamrozik opened this issue Feb 21, 2024 · 2 comments
Assignees
Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Feb 21, 2024

As in subject. Conversation in breaking_changes_confusion_matrix.pptx.

The goal is to make sure that the bottom left rectangle in the following diagram is VersioningReviewRequired instead of the currently deployed implementation of BreakingChangeReviewRequired:

image

Related file:

@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Feb 21, 2024
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 21, 2024
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Feb 21, 2024
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Feb 21, 2024
@konrad-jamrozik konrad-jamrozik changed the title Same-version API check (Swagger BreakingChange) should add VersioningReviewRequired instead of BreakingChangeReviewRequired when detecting issues on preview versions (as opposed to GA) Same-version API check (Swagger BreakingChange) should add VersioningReviewRequired instead of BreakingChangeReviewRequired when detecting issues on preview versions (as opposed to GA) (breaking changes confusion matrix) Mar 8, 2024
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented May 6, 2024

I think I might have actually completed this already - I nee to double check the source.

Update: not yet done

@konrad-jamrozik konrad-jamrozik added the Breaking Changes Improvements to Breaking Changes tooling label Jun 6, 2024
@konrad-jamrozik konrad-jamrozik moved this from 📋 Backlog to 🐝 Dev in Azure SDK EngSys 🚢🎉 Jun 28, 2024
@konrad-jamrozik konrad-jamrozik moved this from 📋 Backlog to 🐝 In Progress in Spec PR Tools Jun 28, 2024
@konrad-jamrozik
Copy link
Contributor Author

  • Pull Request 561778: Fix: add VersioningReviewRequired instead of BreakingChangeReviewRequired same-version preview scenario; svc 0.19.1; bump dependency on svc: ^0.18.0 -> ^0.19.0

@github-project-automation github-project-automation bot moved this from 🐝 In Progress to 🎊 Closed in Spec PR Tools Jul 13, 2024
@github-project-automation github-project-automation bot moved this from 🐝 Dev to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Archived in project
Status: 🎊 Closed
Development

No branches or pull requests

1 participant