Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiView Diff View makes it look like changed property is in a different class #7375

Open
tjprescott opened this issue Nov 30, 2023 · 0 comments
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@tjprescott
Copy link
Member

image

The diff view here make it very clearly look like the property liveOutgoingAudioFIlters it part of the AudioOptions class. However, it's not at all. Turning off the diff view reveals that it is actually part of the Call class. This misleading representation can actually affect what names we recommend so we should preserve the context of what is being diffed rather than just keeping a couple lines on either side of the change.

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 30, 2023
@kurtzeborn kurtzeborn added APIView Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Dec 11, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Dec 11, 2023
@kurtzeborn kurtzeborn moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Dec 11, 2023
@maririos maririos moved this from 🆕 New to 📋 Backlog in ApiView Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: 📋 Backlog
Status: 📋 Backlog
Development

No branches or pull requests

2 participants