Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR Workflow] Add an automatic sign off label for PRs that dont have any API contract changes #7355

Open
rkmanda opened this issue Nov 29, 2023 · 1 comment
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@rkmanda
Copy link
Member

rkmanda commented Nov 29, 2023

We encounter PRs where the author is making some superficial changes that dont have any impact on the API contract.

For eg:

  • Changes to some descriptions
  • Changes only to the readme file
  • Folder restructuring

In such cases we do not see any value in the ARM API reviewer reviewing these PRs. We would like such PRs to be automatically signed off by placing the AutomaticARMSignOff or equivalent label.

Related work:

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Nov 29, 2023
@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Nov 29, 2023

Note: we will also have to update the https://aka.ms/azsdk/pr-diagram and automated PR comments appropriately.

@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Nov 29, 2023
@konrad-jamrozik konrad-jamrozik changed the title Add an automatic sign off label for PRs that dont have any API contract changes [PR Workflow] Add an automatic sign off label for PRs that dont have any API contract changes Nov 29, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Nov 29, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Nov 29, 2023
@konrad-jamrozik konrad-jamrozik added openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 📋 Backlog
Status: 📋 Backlog
Development

No branches or pull requests

2 participants