Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR Workflow] Allow PR authors to merge their PRs once the automated merging criteria is met #7354

Closed
rkmanda opened this issue Nov 29, 2023 · 3 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@rkmanda
Copy link
Member

rkmanda commented Nov 29, 2023

We want to make the ARM swagger PR review process more self-serve. One step towards that is to allow PR authors to merge their own PRs without having to wait for the reviewer to press the merge buttons.

When the PR author requests a merge today, once all required checks pass, the only thing the API reviewer does is to approve the PR and then merge it.

Sometimes there are delays in doing this as the reviewer may be busy with other API reviews or there are holidays in certain timezones or there is a very urgent need from the RP team to perform the merge and they cannot wait until the next business day for the merge to happen. This causes frustration for the PR author and can be easily avoided by giving them merge privileges.

We have developed a lot of confidence over past many months in the automated merging requirements check and we should now make the merge action self-serve.

There is a danger that the PR authors may add all the required labels for a merge and bypass the review process now that they have the ability to merge PRs on their own, however, we are willing to place some trust in our fellow engineers to do the right thing. We can also augment this with some periodic audits, lets say once a month to catch any such attempts.

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Nov 29, 2023
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Nov 29, 2023
@konrad-jamrozik konrad-jamrozik removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Nov 29, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Nov 29, 2023
@konrad-jamrozik konrad-jamrozik changed the title Allow PR authors to merge their PRs once the automated merging criteria is met [PR Workflow] Allow PR authors to merge their PRs once the automated merging criteria is met Dec 1, 2023
@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Mar 25, 2024

Related to:

There is also a related email thread within Azure SDK team with subject RE: Repo permissions model changes

@weshaggard
Copy link
Member

Related to #7648 which is about data-plane merges.

@weshaggard
Copy link
Member

This work has been completed.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Spec PR Tools Aug 1, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Azure SDK EngSys 🚢🎉 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Archived in project
Status: 🎊 Closed
Development

No branches or pull requests

3 participants