Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.net analyzer] check public serialization when Options suffix is found #7257

Open
archerzz opened this issue Nov 8, 2023 · 2 comments
Open

[.net analyzer] check public serialization when Options suffix is found #7257

archerzz opened this issue Nov 8, 2023 · 2 comments
Assignees
@archerzz
Labels
Client This issue points to a problem in the data-plane of the library. .NETClientSDKAnalyzers

Comments

@archerzz
Copy link
Member

archerzz commented Nov 8, 2023

Description

A follow-up of #7247 See review comments.

We should include public serialization when checking Options suffix of model names.

This should be done when public serialization is released.
@archerzz archerzz mentioned this issue Nov 8, 2023
Merged
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 8, 2023
@kurtzeborn kurtzeborn added Client This issue points to a problem in the data-plane of the library. .NETClientSDKAnalyzers and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 13, 2023
@kurtzeborn
Copy link
Member

Just a guess that @JoshLove-msft should get this. Please reassign as appropriate.

@archerzz archerzz assigned archerzz and unassigned JoshLove-msft Nov 14, 2023
@archerzz
Copy link
Member Author

Just a guess that @JoshLove-msft should get this. Please reassign as appropriate.

@kurtzeborn Sorry I should assign it to myself when I created it. It's a follow-up when reviewing my implementation of analyzer rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archerzz archerzz

Labels
Client This issue points to a problem in the data-plane of the library. .NETClientSDKAnalyzers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@archerzz @kurtzeborn @JoshLove-msft