Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIView: can we change 'Approvers' to 'Approved by'? #6129

Closed
richardpark-msft opened this issue May 9, 2023 · 3 comments
Closed

APIView: can we change 'Approvers' to 'Approved by'? #6129

richardpark-msft opened this issue May 9, 2023 · 3 comments
Assignees
@yeojunh
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@richardpark-msft
Copy link
Member

In the screenshot I didn't realize that the Approvers had actually approved it. I thought it was telling me who could approve it. I think a little rename of the label would make it clear.

image
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView May 9, 2023
@maririos maririos removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 9, 2023
@mikekistler mikekistler moved this from 🆕 New to 📋 Backlog in ApiView May 15, 2023
@maririos maririos added Central-EngSys This issue is owned by the Engineering System team. Intern Work assigned to our great interns labels May 17, 2023
@chidozieononiwu
Copy link
Member

Requires update to https://github.com/Azure/azure-sdk-tools/blob/ffe81dfa74a95d5d5df3bf97217b154e15957047/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml#LL95C31-L95C31

@praveenkuttappan praveenkuttappan moved this from 📋 Backlog to 🏗 In progress in ApiView Jun 2, 2023
@praveenkuttappan praveenkuttappan mentioned this issue Jun 2, 2023
Merged
@praveenkuttappan praveenkuttappan moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Jun 2, 2023
@yeojunh yeojunh moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jun 2, 2023
@yeojunh yeojunh moved this from 🏗 In progress to ✅ Done in ApiView Jun 5, 2023
@richardpark-msft
Copy link
Member Author

Thanks all, I knew if I believed in the process it would pay back.

@maririos
Copy link
Member

maririos commented Jun 9, 2023

Thanks all, I knew if I believed in the process it would pay back.

You will see the changes after our deployment next week :)

@chidozieononiwu chidozieononiwu removed the Intern Work assigned to our great interns label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeojunh yeojunh

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maririos @chidozieononiwu @yeojunh @richardpark-msft