-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR Workflow] Update REST API PR labeling bot for TypeSpec rename #5917
Comments
Ideally to be fixed within the next 30 days. |
If this is enabled, this could be used by the Release Planner apps and we can stop asking for this data manually. |
export function isSwaggerGeneratedByCadl(swaggerFilePath:string) {
try {
return !!JSON.parse(readFileSync(swaggerFilePath).toString())?.info['x-cadl-generated']
}
catch{
return false
}
} @weshaggard @mikeharder looks like we have automation that when it detects {
"swagger": "2.0",
"info": {
"title": "Microsoft.VoiceServices",
"version": "2023-01-31",
"x-cadl-generated": [
{
"emitter": "@azure-tools/cadl-autorest"
}
]
}, Example of automation adding |
@mikekistler thank you for the attribute name pointer! When I at first used GitHub search to find attributes like that it returned no results. I think I wasn't paying enough attention and had a bug in my search query (: |
Closed as implemented and deployed. For details, see here: |
Some time back we added support in our labelling bot to add the "Cadl" label to any PRs that included files with the ".cadl" suffix. With the rename of Cadl to TypeSpec, we need to update this automation to look for files with the ".tsp" suffix and when found add the "TypeSpec" label (I already created the label).
Related work:
TypeSpec
label if appropriate files are changed #7353The text was updated successfully, but these errors were encountered: