Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIView - Outdated instructions to create API review for C++. #5767

Closed
praveenkuttappan opened this issue Mar 21, 2023 · 0 comments · Fixed by #5787
Closed

APIView - Outdated instructions to create API review for C++. #5767

praveenkuttappan opened this issue Mar 21, 2023 · 0 comments · Fixed by #5787
Assignees
@chidozieononiwu
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

C++ API reviews are created using new API parser for C++. But APIView still shows old instructions to create API review for C++.
New C++ API Parser: https://github.com/Azure/azure-sdk-tools/tree/main/tools/apiview/parsers/cpp-api-parser#readme

We should update the instructions to refer to above README and upload generated token file.

Current instruction on APIView.
image
@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Mar 21, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Mar 21, 2023
@chidozieononiwu chidozieononiwu mentioned this issue Mar 23, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🤔Triage to 🎊Closed in Azure SDK EngSys 🚢🎉 Mar 23, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in ApiView Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update C++ Instructions chidozieononiwu/azure-sdk-tools
2 participants
@chidozieononiwu @praveenkuttappan