Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIView - TypeSpec - API review is not generated if PR has more than one project changes #5751

Closed
Tracked by #5761
praveenkuttappan opened this issue Mar 20, 2023 · 0 comments
Assignees
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

API review is generated at TypeSpec project level. API review is not generated if a TypeSpec PR changes more than once project. We have seen swagger PRs that changes more than one RP in same PR. So similar support is required if TypeSpec PR has multi project changes.

Reason: current logic looks for a common parent directory across all modified typespec files and this can lead to non-project parent root directory and API review gen step will fail.

Fix: API review gen step should be run on each project root directory for the modified files and generate API review.

@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Mar 20, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Mar 20, 2023
@mikekistler mikekistler moved this from 🆕 New to 📋 Backlog in ApiView Mar 20, 2023
@praveenkuttappan praveenkuttappan moved this from 📋 Backlog to 🏗 In progress in ApiView Mar 28, 2023
@praveenkuttappan praveenkuttappan moved this from 🏗 In progress to 📋 Backlog in ApiView Mar 28, 2023
@praveenkuttappan praveenkuttappan moved this from 📋 Backlog to 🏗 In progress in ApiView Mar 29, 2023
@praveenkuttappan praveenkuttappan self-assigned this Mar 29, 2023
@praveenkuttappan praveenkuttappan moved this from 🤔Triage to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Mar 30, 2023
@praveenkuttappan praveenkuttappan moved this from 🏗 In progress to ✅ Done in ApiView Apr 3, 2023
@github-project-automation github-project-automation bot moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant