Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger API review - Skip API review step if swagger is not part of default tag #5740

Closed
Tracked by #5761
praveenkuttappan opened this issue Mar 17, 2023 · 1 comment
Closed
Tracked by #5761

Swagger API review - Skip API review step if swagger is not part of default tag #5740

praveenkuttappan opened this issue Mar 17, 2023 · 1 comment
Assignees
@chidozieononiwu @praveenkuttappan
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

Swagger PR pipeline step to create API review fails if modified swagger file is not part of default tag. We should ignore the failure instead of marking pipeline as failed in this case until we have the support added to create API review from non-default tag.

Issue to track long term fix: #5739
@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Mar 17, 2023
@praveenkuttappan praveenkuttappan self-assigned this Mar 17, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Mar 17, 2023
@mikekistler mikekistler moved this from 🆕 New to 📋 Backlog in ApiView Mar 20, 2023
@maririos maririos mentioned this issue Mar 21, 2023
Closed
@github-project-automation github-project-automation bot moved this from 🤔 Triage to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jul 27, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in ApiView Jul 27, 2023
@chidozieononiwu
Copy link
Member

This has been resolved by @praveenkuttappan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

@praveenkuttappan praveenkuttappan

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chidozieononiwu @praveenkuttappan