Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwaggerAPIView fallback machanism by using changed swagger files directly #5521

Closed
Tracked by #5761
ruowan opened this issue Feb 20, 2023 · 1 comment
Closed
Tracked by #5761

SwaggerAPIView fallback machanism by using changed swagger files directly #5521

ruowan opened this issue Feb 20, 2023 · 1 comment
Assignees
@chidozieononiwu @praveenkuttappan
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. Swagger Issues for APIView support of Swagger

Comments

@ruowan
Copy link
Member

ruowan commented Feb 20, 2023 •
edited
Loading

In some spec PRs, the readme tag format is wrong. It cause our pipeline cannot found affected readme tag and swaggerAPIView cannot be generated.

We want every changes should have APIView. So in above case, we will directly use changed swagger file to do APIView. And also this fallback machanism will suport cadl+dpg scenario which without readme file.

Here is a sample PR Azure/azure-rest-api-specs#22331
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 20, 2023
@ruowan ruowan added APIView and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 20, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Feb 20, 2023
@ruowan ruowan self-assigned this Feb 20, 2023
@mikekistler mikekistler added Central-EngSys This issue is owned by the Engineering System team. Swagger Issues for APIView support of Swagger labels Feb 23, 2023
@mikekistler mikekistler moved this from 🆕 New to 📋 Backlog in ApiView Feb 23, 2023
@ruowan ruowan assigned praveenkuttappan and unassigned ruowan Mar 15, 2023
@maririos maririos mentioned this issue Mar 21, 2023
Closed
@chidozieononiwu chidozieononiwu mentioned this issue Jun 6, 2023
Closed
11 tasks
@chidozieononiwu
Copy link
Member

For this we should just inform PR owners to update their readme with the correct tag.

@github-project-automation github-project-automation bot moved this from 🤔 Triage to 🎊 Closed in Azure SDK EngSys 🚢🎉 Aug 10, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in ApiView Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

@praveenkuttappan praveenkuttappan

Labels
APIView Central-EngSys This issue is owned by the Engineering System team. Swagger Issues for APIView support of Swagger
Projects
ApiView
Status: ✅ Done
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chidozieononiwu @ruowan @praveenkuttappan @mikekistler