Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable credscan in assets repositories #4124

Closed
2 tasks
scbedd opened this issue Sep 14, 2022 · 3 comments
Closed
2 tasks

Enable credscan in assets repositories #4124

scbedd opened this issue Sep 14, 2022 · 3 comments
Assignees
@scbedd
Labels
Asset-Sync Any issues relating to moving test assets out of repos. Central-EngSys This issue is owned by the Engineering System team.

Comments

@scbedd
Copy link
Member

scbedd commented Sep 14, 2022 •
edited
Loading

  • azure-sdk-assets
  • azure-sdk-assets-integration
@scbedd scbedd added Central-EngSys This issue is owned by the Engineering System team. Asset-Sync Any issues relating to moving test assets out of repos. labels Sep 14, 2022
@scbedd scbedd moved this to 🤔Triage in Azure SDK EngSys 🚢🎉 Sep 14, 2022
@scbedd scbedd changed the title Enable credscan in azure-sdk-assets repository Enable credscan in assets repositories Sep 14, 2022
@scbedd
Copy link
Member Author

scbedd commented Sep 14, 2022

@sima-zhu FYI

@kurtzeborn kurtzeborn moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Sep 19, 2022
@scbedd
Copy link
Member Author

scbedd commented Sep 20, 2022

Additional piece of feedback from Wes, lets ensure that the credcan error message links out to aka.ms with a description on how to fix, bypass, ignore, etc.

Additionally, is there anything we can do to have the proxy credscan have a couple default ignores/sanitizers?

@scbedd
Copy link
Member Author

scbedd commented Feb 9, 2023

Closing in favor of #1950

@scbedd scbedd closed this as completed Feb 10, 2023
@github-project-automation github-project-automation bot moved this from 📋Backlog to 🎊Closed in Azure SDK EngSys 🚢🎉 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scbedd scbedd

Labels
Asset-Sync Any issues relating to moving test assets out of repos. Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scbedd