Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-version breaking change when adding x-ms-enum wasn't flagged in CI #4073

Closed
jhendrixMSFT opened this issue Sep 6, 2022 · 2 comments
Closed

Cross-version breaking change when adding x-ms-enum wasn't flagged in CI #4073

jhendrixMSFT opened this issue Sep 6, 2022 · 2 comments
Assignees
@jianyexi
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@jhendrixMSFT
Copy link
Member

The following PR introduced a new API version for storage (control-plane).

Azure/azure-rest-api-specs#19357

In common.json, CorsRule.allowedMethods had the x-ms-enum extension added to control the name and not rely on an auto-generated one. This resulted in a different name from the previous API version which didn't have the x-ms-enum extension.

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/storage/resource-manager/Microsoft.Storage/stable/2021-09-01/common.json#L32

This was not flagged as a cross-API version breaking change when it should have been.

CC @mikekistler
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 6, 2022
@mikekistler mikekistler added Spec PR Tools Tooling that runs in azure-rest-api-specs repo. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 6, 2022
@tadelesh tadelesh mentioned this issue Sep 7, 2022
Closed
@raych1
Copy link
Member

raych1 commented Oct 14, 2022

@jianyexi , can you provide update?

@jianyexi
Copy link

already fixed

@jianyexi jianyexi moved this to Done in Spec PR Tools Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jianyexi jianyexi

Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jhendrixMSFT @raych1 @jianyexi @mikekistler