Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition to GitHub-native auto-merge feature #1289

Closed
mitchdenny opened this issue Dec 17, 2020 · 4 comments
Closed

Transition to GitHub-native auto-merge feature #1289

mitchdenny opened this issue Dec 17, 2020 · 4 comments
Assignees
@weshaggard
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Comments

@mitchdenny
Copy link
Contributor

Currently we make use of fabric bot to auto-merge PRs which have the auto merge label once all the checks have passed in the PR is approved. GitHub recently rolled out a native automerge feature so we should plan on moving to that. This work will involve:

  1. Try out automerge in a repo and make sure it works as advertised.
  2. Change automation that creates PRs with automerge labels (e.g. eng common sync) to set auto merge flag instead.
  3. Disable the fabric bot rules.

It isn't clear at this point whether automerge settings are exposed on the REST API. This would probably be the initial investigation.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 17, 2020
@weshaggard weshaggard added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Jan 4, 2021
@kurtzeborn kurtzeborn removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 4, 2021
@sima-zhu
Copy link
Contributor

https://support.github.com/ticket/personal/0/982959

@kurtzeborn kurtzeborn assigned weshaggard and unassigned sima-zhu Jan 30, 2023
@kurtzeborn kurtzeborn moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Jan 30, 2023
@weshaggard
Copy link
Member

We should use the gh pr merge <number> --auto for automation that wants to enable automatic merging. This is going to need to be done soon as we move away from fabric bot supporting auto-merge label

@scbedd scbedd mentioned this issue May 11, 2023
Merged
@weshaggard
Copy link
Member

I've been testing some of this in the azure-sdk repo at https://github.com/Azure/azure-sdk/blob/main/eng/pipelines/version-updater.yml#L91-L97

@weshaggard
Copy link
Member

Closing in favor of Azure/azure-sdk#5832

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weshaggard weshaggard

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mitchdenny @weshaggard @kurtzeborn @chidozieononiwu @sima-zhu