From b70dac64619973fcf759d16a6e51960267270fc9 Mon Sep 17 00:00:00 2001 From: Wes Haggard Date: Fri, 24 Mar 2023 11:17:21 -0700 Subject: [PATCH] Explicitly set PSNativeCommandArgumentPassing to Legacy for git push script (#5794) https://learn.microsoft.com/en-us/powershell/scripting/learn/experimental-features?view=powershell-7.3#psnativecommandargumentpassing Do to that breaking change in PS 7.3 we need to opt into the legacy arg parsing. --- eng/common/scripts/git-branch-push.ps1 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/eng/common/scripts/git-branch-push.ps1 b/eng/common/scripts/git-branch-push.ps1 index 3e012a1f283..edd792ffd8c 100644 --- a/eng/common/scripts/git-branch-push.ps1 +++ b/eng/common/scripts/git-branch-push.ps1 @@ -37,6 +37,10 @@ param( [boolean] $AmendCommit = $false ) +# Explicit set arg parsing to Legacy mode because some of the git calls in this script depend on empty strings being empty and not passing a "" git. +# more info https://learn.microsoft.com/en-us/powershell/scripting/learn/experimental-features?view=powershell-7.3#psnativecommandargumentpassing +$PSNativeCommandArgumentPassing = "Legacy" + # This is necessary because of the git command output writing to stderr. # Without explicitly setting the ErrorActionPreference to continue the script # would fail the first time git wrote command output.