From 823cb6609769726b16390d8e4cb9de80cfd11475 Mon Sep 17 00:00:00 2001 From: Konrad Jamrozik Date: Thu, 2 Feb 2023 12:46:33 -0800 Subject: [PATCH] improve warnings --- .../CodeOwnersParser/MatchedCodeownersEntry.cs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/code-owners-parser/CodeOwnersParser/MatchedCodeownersEntry.cs b/tools/code-owners-parser/CodeOwnersParser/MatchedCodeownersEntry.cs index 53fe3bf25466..49d66282c519 100644 --- a/tools/code-owners-parser/CodeOwnersParser/MatchedCodeownersEntry.cs +++ b/tools/code-owners-parser/CodeOwnersParser/MatchedCodeownersEntry.cs @@ -163,7 +163,8 @@ private static bool ContainsUnsupportedSequences(string codeownersPath) { Console.Error.WriteLine( $"CODEOWNERS path \"{codeownersPath}\" ends with " + - "unsupported sequence of \"/**\". Replace it with \"/\"."); + "unsupported sequence of \"/**\". Replace it with \"/\". " + + "Until then this path will never match."); return true; } @@ -173,7 +174,8 @@ private static bool ContainsUnsupportedSequences(string codeownersPath) { Console.Error.WriteLine( $"CODEOWNERS path \"{codeownersPath}\" ends with " + - "unsupported sequence of \"/**/\". Replace it with \"/\"."); + "unsupported sequence of \"/**/\". Replace it with \"/\". " + + "Until then this path will never match."); return true; } @@ -184,8 +186,9 @@ private static bool ContainsUnsupportedSequences(string codeownersPath) { Console.Error.WriteLine( $"CODEOWNERS path \"{codeownersPath}\" contains " + - "unsupported sequence of \"**\" that is not \"/**/\". Replace it with \"*\". " + - "Until then this path will never match."); + "unsupported sequence of \"**\". Double star can be used only within slashes \"/**/\" " + + "or as a top-level catch all path of \"/**\". " + + "This path will never match."); return true; }