From 4da5527d041dc0e60077dc27aca3fb0e362aca43 Mon Sep 17 00:00:00 2001 From: Konrad Jamrozik Date: Mon, 13 Feb 2023 15:57:30 -0800 Subject: [PATCH] Comment update: clarify we need `sdk` in `install-dotnet.yml` due to `asp.net core` runtime (#5428) --- eng/pipelines/templates/steps/install-dotnet.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/eng/pipelines/templates/steps/install-dotnet.yml b/eng/pipelines/templates/steps/install-dotnet.yml index 06a8d129b72..9e2c9d2769e 100644 --- a/eng/pipelines/templates/steps/install-dotnet.yml +++ b/eng/pipelines/templates/steps/install-dotnet.yml @@ -16,7 +16,12 @@ steps: retryCountOnTaskFailure: 3 inputs: # We must install sdk, not just runtime, as it is required by some of our tools, like test-proxy. - # For additional context, see PR: https://github.com/Azure/azure-sdk-tools/pull/5405 + # Specifically, test-proxy requires asp.net core runtime, which is installed only when sdk option + # is selected, per: https://github.com/microsoft/azure-pipelines-tasks/issues/14405 + # + # For additional context, see: + # https://github.com/Azure/azure-sdk-tools/pull/5405#discussion_r1105006774 + # https://github.com/Azure/azure-sdk-tools/pull/5405 packageType: sdk version: 6.0.x # performMultiLevelLookup comes into play when given .NET executable target runtime is different @@ -24,4 +29,4 @@ steps: performMultiLevelLookup: true # Future work: add NuGet packages caching. See: -# https://github.com/Azure/azure-sdk-tools/issues/5086 \ No newline at end of file +# https://github.com/Azure/azure-sdk-tools/issues/5086