From 610758dca281f44b5f87e2c4687af6b22337d1b8 Mon Sep 17 00:00:00 2001 From: "Scott Beddall (from Dev Box)" Date: Tue, 30 Apr 2024 12:26:07 -0700 Subject: [PATCH 1/2] repair test again --- .../test-proxy/Azure.Sdk.Tools.TestProxy.Tests/LoggingTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/LoggingTests.cs b/tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/LoggingTests.cs index ce7e7b4f0e6..98af4a47d68 100644 --- a/tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/LoggingTests.cs +++ b/tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/LoggingTests.cs @@ -52,7 +52,7 @@ public async Task PlaybackLogsSanitizedRequest() HttpResponse response = new DefaultHttpContext().Response; await testRecordingHandler.HandlePlaybackRequest(recordingId, request, response); - AssertLogs(logger, 4, 8, 7); + AssertLogs(logger, 4, 8, 12); } finally { From e97e7f22b2e8280004a457e600e331d9bf30b5b7 Mon Sep 17 00:00:00 2001 From: Scott Beddall <45376673+scbedd@users.noreply.github.com> Date: Tue, 30 Apr 2024 15:41:50 -0700 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> --- .../Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs index fec616d4767..d64fd32bc5a 100644 --- a/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs +++ b/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs @@ -449,11 +449,11 @@ public SanitizerDictionary() { "AZSDK3443" ), new RegisteredSanitizer( - new BodyKeySanitizer("$..principalId"), + new BodyKeySanitizer("$..principalId", value: EMPTYGUID), "AZSDK3444" ), new RegisteredSanitizer( - new BodyKeySanitizer("$..clientId"), + new BodyKeySanitizer("$..clientId", value: EMPTYGUID), "AZSDK3445" ), new RegisteredSanitizer(