Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix online deployment registry issue #37857

Conversation

PratibhaShrivastav18
Copy link
Member

Description

Issue identified via ICM. Online deployment fails when model is kept in registry in different subscription

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

…into shrivastavp/deployment_registry_issue_fix
@PratibhaShrivastav18
Copy link
Member Author

/check-enforcer override

Copy link
Member

@jayesh-tanna jayesh-tanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any unit test case require for this change?

@PratibhaShrivastav18
Copy link
Member Author

PratibhaShrivastav18 commented Oct 15, 2024

any unit test case require for this change?

Currently we are creating 15+ service clients in ml client. There is a huge gap here if we plan to write unit tests to check service client objects creation and it's a huge effort. I've still created a backlog work item for this, but it's not in the scope of this PR.

@kshitij-microsoft
Copy link
Member

The code looks good, but since it is touching the ML Client, please consider all the use cases it might affect.

@PratibhaShrivastav18 PratibhaShrivastav18 merged commit 826c27e into Azure:main Oct 15, 2024
37 checks passed
@PratibhaShrivastav18 PratibhaShrivastav18 deleted the shrivastavp/deployment_registry_issue_fix branch October 15, 2024 10:34
kshitij-microsoft pushed a commit that referenced this pull request Oct 21, 2024
* fix service client subscription id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants