-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix online deployment registry issue #37857
Fix online deployment registry issue #37857
Conversation
API change check API changes are not detected in this pull request. |
…into shrivastavp/deployment_registry_issue_fix
/check-enforcer override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any unit test case require for this change?
Currently we are creating 15+ service clients in ml client. There is a huge gap here if we plan to write unit tests to check service client objects creation and it's a huge effort. I've still created a backlog work item for this, but it's not in the scope of this PR. |
The code looks good, but since it is touching the ML Client, please consider all the use cases it might affect. |
* fix service client subscription id
Description
Issue identified via ICM. Online deployment fails when model is kept in registry in different subscription
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines