From fda48bd76631f94ae54c8fa5e2e01bb23f82f643 Mon Sep 17 00:00:00 2001 From: unknown <424401670@qq.com> Date: Wed, 30 Mar 2022 13:34:24 +0800 Subject: [PATCH 1/4] update change_log --- tools/azure-sdk-tools/packaging_tools/change_log.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/azure-sdk-tools/packaging_tools/change_log.py b/tools/azure-sdk-tools/packaging_tools/change_log.py index fd5a43834646..42a36fe79915 100644 --- a/tools/azure-sdk-tools/packaging_tools/change_log.py +++ b/tools/azure-sdk-tools/packaging_tools/change_log.py @@ -67,7 +67,8 @@ def operation(self, diff_entry): return # Is this a new operation, inside a known operation group? - function_name, *remaining_path = remaining_path + function_name, change_parameter_name, *remaining_path = remaining_path + print(remaining_path) if not remaining_path: if is_deletion: self.breaking_changes.append(_REMOVE_OPERATION.format(operation_name, function_name)) @@ -80,7 +81,7 @@ def operation(self, diff_entry): return # So method signaure changed. Be vague for now - self.breaking_changes.append(_SIGNATURE_CHANGE.format(operation_name, function_name)) + self.breaking_changes.append(_SIGNATURE_CHANGE.format(operation_name, function_name, change_parameter_name)) def models(self, diff_entry): path, is_deletion = self._unpack_diff_entry(diff_entry) @@ -144,7 +145,7 @@ def models(self, diff_entry): ## Breaking Changes _REMOVE_OPERATION_GROUP = "Removed operation group {}" _REMOVE_OPERATION = "Removed operation {}.{}" -_SIGNATURE_CHANGE = "Operation {}.{} has a new signature" +_SIGNATURE_CHANGE = "Operation {}.{} has a new signature {}" _MODEL_SIGNATURE_CHANGE = "Model {} has a new signature" _MODEL_PARAM_DELETE = "Model {} no longer has parameter {}" _MODEL_PARAM_ADD_REQUIRED = "Model {} has a new required parameter {}" @@ -220,4 +221,4 @@ def main(base, latest): logging.basicConfig(level=logging.DEBUG if args.debug else logging.INFO) - print(main(args.base, args.latest)) + print(main(args.base, args.latest)) \ No newline at end of file From 566a04ad74a87ffc6d72becbcbb644dc5b481cbf Mon Sep 17 00:00:00 2001 From: zhenbiao wei <424401670@qq.com> Date: Wed, 30 Mar 2022 13:40:59 +0800 Subject: [PATCH 2/4] Update change_log.py --- tools/azure-sdk-tools/packaging_tools/change_log.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/azure-sdk-tools/packaging_tools/change_log.py b/tools/azure-sdk-tools/packaging_tools/change_log.py index 42a36fe79915..87ef66024f59 100644 --- a/tools/azure-sdk-tools/packaging_tools/change_log.py +++ b/tools/azure-sdk-tools/packaging_tools/change_log.py @@ -68,7 +68,6 @@ def operation(self, diff_entry): # Is this a new operation, inside a known operation group? function_name, change_parameter_name, *remaining_path = remaining_path - print(remaining_path) if not remaining_path: if is_deletion: self.breaking_changes.append(_REMOVE_OPERATION.format(operation_name, function_name)) @@ -221,4 +220,4 @@ def main(base, latest): logging.basicConfig(level=logging.DEBUG if args.debug else logging.INFO) - print(main(args.base, args.latest)) \ No newline at end of file + print(main(args.base, args.latest)) From c851c77dcc1dab0372ba88c68e8f5f72a37da80a Mon Sep 17 00:00:00 2001 From: Yuchao Yan Date: Wed, 30 Mar 2022 13:41:53 +0800 Subject: [PATCH 3/4] Update tools/azure-sdk-tools/packaging_tools/change_log.py --- tools/azure-sdk-tools/packaging_tools/change_log.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/azure-sdk-tools/packaging_tools/change_log.py b/tools/azure-sdk-tools/packaging_tools/change_log.py index 87ef66024f59..c23303973d1c 100644 --- a/tools/azure-sdk-tools/packaging_tools/change_log.py +++ b/tools/azure-sdk-tools/packaging_tools/change_log.py @@ -67,7 +67,7 @@ def operation(self, diff_entry): return # Is this a new operation, inside a known operation group? - function_name, change_parameter_name, *remaining_path = remaining_path + function_name, parameter_name, *remaining_path = remaining_path if not remaining_path: if is_deletion: self.breaking_changes.append(_REMOVE_OPERATION.format(operation_name, function_name)) From de18e10282a727d182e73acd32e74be07dd3f3a5 Mon Sep 17 00:00:00 2001 From: Yuchao Yan Date: Wed, 30 Mar 2022 13:42:16 +0800 Subject: [PATCH 4/4] Update tools/azure-sdk-tools/packaging_tools/change_log.py --- tools/azure-sdk-tools/packaging_tools/change_log.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/azure-sdk-tools/packaging_tools/change_log.py b/tools/azure-sdk-tools/packaging_tools/change_log.py index c23303973d1c..1f6eed9faae7 100644 --- a/tools/azure-sdk-tools/packaging_tools/change_log.py +++ b/tools/azure-sdk-tools/packaging_tools/change_log.py @@ -80,7 +80,7 @@ def operation(self, diff_entry): return # So method signaure changed. Be vague for now - self.breaking_changes.append(_SIGNATURE_CHANGE.format(operation_name, function_name, change_parameter_name)) + self.breaking_changes.append(_SIGNATURE_CHANGE.format(operation_name, function_name, parameter_name)) def models(self, diff_entry): path, is_deletion = self._unpack_diff_entry(diff_entry)