Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new line delimiter #23262

Merged
merged 3 commits into from
Mar 1, 2022
Merged

fix new line delimiter #23262

merged 3 commits into from
Mar 1, 2022

Conversation

xiangyan99
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Azure.Core label Mar 1, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-cosmos. You can review API changes here

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no it was really everywhere. Thanks for fixing!

@xiangyan99 xiangyan99 marked this pull request as ready for review March 1, 2022 20:35
@xiangyan99
Copy link
Member Author

/azp run python - autorest - pr

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiangyan99
Copy link
Member Author

#23261

@xiangyan99 xiangyan99 merged commit 3f0c457 into main Mar 1, 2022
@xiangyan99 xiangyan99 deleted the core_fix_new_line_delimiter branch March 1, 2022 21:49
@@ -8,6 +8,8 @@

### Bugs Fixed

- use "\n" rather than "/n" for new line in log #23261
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking: should be "Use".

rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
* fix new line delimiter

* update

* update
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
* fix new line delimiter

* update

* update
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Mar 30, 2023
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2022-10-01 (Azure#23262)

merged with breaking change approved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants