Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiohttp: Unclosed client session #8990

Closed
chlowell opened this issue Dec 4, 2019 · 0 comments · Fixed by #9090
Closed

aiohttp: Unclosed client session #8990

chlowell opened this issue Dec 4, 2019 · 0 comments · Fixed by #9090
Assignees
@chlowell
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2020] January

Comments

@chlowell
Copy link
Member

chlowell commented Dec 4, 2019

Async credentials don't close aiohttp sessions. So a program like this:

cred = ClientSecretCredential(...)
await cred.get_token('some scope')

Outputs this on exit:

[c:\python37\Lib\asyncio\base_events.py] Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x0000016A8BDB6A58>
[c:\python37\Lib\asyncio\base_events.py] Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x0000016A8BF3A1C8>, 1617014.562)]']
connector: <aiohttp.connector.TCPConnector object at 0x0000016A8BDB6A90>

Related: #7228
@chlowell chlowell added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Dec 4, 2019
@chlowell chlowell self-assigned this Dec 4, 2019
@chlowell chlowell added this to the [2020] January milestone Dec 4, 2019
@chlowell chlowell mentioned this issue Dec 4, 2019
Closed
@chlowell chlowell mentioned this issue Dec 11, 2019
Merged
@andersbogsnes andersbogsnes mentioned this issue Nov 16, 2020
Closed
@cyberpion-yotam cyberpion-yotam mentioned this issue Feb 16, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chlowell chlowell

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2020] January
Development

Successfully merging a pull request may close this issue.

Expose methods for closing async credential transport sessions chlowell/azure-sdk-for-python
1 participant
@chlowell