Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clients leak generated KeyVaultErrorException #7003

Closed
chlowell opened this issue Aug 29, 2019 · 1 comment · Fixed by #7086
Closed

Clients leak generated KeyVaultErrorException #7003

chlowell opened this issue Aug 29, 2019 · 1 comment · Fixed by #7086
Assignees
@chlowell
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@chlowell
Copy link
Member

In addition to being versioned, this class isn't part of the public surface, making it difficult to handle.
@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. KeyVault labels Aug 29, 2019
@chlowell chlowell mentioned this issue Sep 6, 2019
Merged
@chlowell chlowell self-assigned this Sep 6, 2019
@chlowell
Copy link
Member Author

chlowell commented Sep 6, 2019

Leaking the generated exceptions is okay (they inherit HttpResponseError) but we should ensure that when we substitute other exceptions like ResourceNotFoundError we include error details from Key Vault.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chlowell chlowell

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More useful exceptions for Key Vault errors chlowell/azure-sdk-for-python
1 participant
@chlowell