-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parts of deprecated msrestazure aren't ported to any other library #29023
Comments
Thanks for your issue @gabuniag, we'll get back to you asap. |
Hi @kristapratico @lmazuel @johanste, is resolution of this issue still in the plans? Thanks! |
@tbennett0 , @xiangyan99 is working on this as we speak |
Has there been any progress here? Please see the documentation issue in which it's mentioned above. Thanks! |
@lmazuel -- are there any updates here? Thanks! |
We got sidetracked, but @xiangyan99 is still working on this as available. |
hate to ask again but this has been worked on since August? is there a planned release date? |
Any chances to get this moved to supported lib? |
Here is an update: we added the list of the supported clouds in https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/core/azure-core/azure/core/_azure_clouds.py and the mapping from azure_cloud to the resource_manager & credential_scopes information in We will add the mapping from azure_cloud to the authority information in azure-identity library and will keep you updated. |
Issue:
The msrestazure package has been deprecated for quite some time:
This package is deprecated and no longer receives updates The authentication part of this package has been moved to [azure-identity](https://pypi.org/project/azure-identity/) The other parts of this library are covered by [azure-mgmt-core](https://pypi.org/project/azure-mgmt-core/)
https://github.com/Azure/msrestazure-for-python
This package contains a "Cloud" class, which is necessary to work with various government clouds:
https://github.com/Azure/msrestazure-for-python/blob/8e3def8c9927a349596e575de93df76de7a3a2b6/msrestazure/azure_cloud.py#L113
and its instances that have various URL-s hardcoded: https://github.com/Azure/msrestazure-for-python/blob/8e3def8c9927a349596e575de93df76de7a3a2b6/msrestazure/azure_cloud.py#L169
Per learning.microsoft.com, those class instances are used to connect to a government cloud: https://learn.microsoft.com/en-us/azure/developer/python/sdk/azure-sdk-sovereign-domain
Such a class, that would provide similar constants is not implemented elsewhere in the Azure ecosystem.
Suggested Solution
Code found in https://github.com/Azure/msrestazure-for-python/blob/master/msrestazure/azure_cloud.py should be ported to azure-identity. This will allow developers to completely deprecate msrestazure from their codebase.
Why this is important
Since there is no alternative authoritative source of the constants found in AZURE_PUBLIC_CLOUD, AZURE_CHINA_CLOUD, AZURE_US_GOV_CLOUD, AZURE_GERMAN_CLOUD, various azure-related projects need to either:
Depend on a deprecated project
or:
Implement "Cloud" class and its instances locally, thus having to maintain it locally.
Both solutions seem bad.
The text was updated successfully, but these errors were encountered: